[1.20.6] Use stack hash strategy for mutable map in creative tab event #1043
Conversation
|
|
Uhhh. Are you positive you are not going to reintroduce this bug where the creative menu enchanted books gets broken or order incorrectly? #920 I feel like there was some issue I had before with the hashing and enchanted books in the menu. And had to remove the hashing in order to allow the enchanted books to show up properly |
|
I was not aware of that issue. This does reintroduce that bug. If this does not have a proper solution, then a better error should at least be implemented along with an explanation on the event hook with why the custom hash strategy cannot be used. |
|
If testing and the enchanted book bug doesn’t happen, then this pr should be alright. Though maybe we should have a junit test added to verify that two of exact same item errors but enchanted books passes. See my Neo startup config PR for an example of a junit test that is also a test mod |
|
ah I see how vanilla bypasses their enchanted books. They deliberately skip checking search only entries lmao. Tested PR and it does break the books tho. While the enchanted books do show up in the search, the normal books are not showing under the Ingredients tabs. I think this PR's fix needs to change to allow duplicate itemstacks if the duplicates are search only mode. Also note, vanilla's check is actually order dependent too! So if you add search only itemstack first, and then the normal tab itemstack, you hit the duplicate exception error. But not the other way around. So that check will also need to be added to neo |
Not a big fan of the impl. Honestly would rather just remove the map entirely and use something else
Vanilla disallows duplicate elements in creative mode tabs, throwing a pretty unhelpful error:
The current
BuildCreativeModeTabContentsEventmutable entries map does allow duplicate elements due to using default object comparison and hashing. This PR changes the hash strategy used toItemStackLinkedSet#TYPE_AND_TAGFixes #1040.