Fix EffectCure syncing by introducing connection aware StreamCodec

[RaymondBlaze]

Due to the nature of the StreamCodec, modifying vanilla StreamCodecs due to NeoForge's extra data has always been hard when it comes to keep NeoForge<->Vanilla connection compatibility.

In some cases, we can make use of unused fields like list size (like in the Ingredient's StreamCodec) to conditionally write or read NeoForge specific data, but that's not always applicable, like #986.

The workaround for #986 in this PR is to patch RegistryFriendlyByteBuf to let it contain NeoForge's ConnectionType and thus providing context for StreamCodec to handle serialization/deserialization differently for NEOFORGE and OTHER connections.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: e71a8d4206bebeae304a4e0aa6f0168b080f3685.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:20.6.121-beta-pr-1041-connection-aware-stream-codec
• 📦 net.neoforged:testframework:20.6.121-beta-pr-1041-connection-aware-stream-codec

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1041' // https://github.com/neoforged/NeoForge/pull/1041
        url 'https://prmaven.neoforged.net/NeoForge/pr1041'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1041.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1041
cd NeoForge-pr1041
curl -L https://prmaven.neoforged.net/NeoForge/pr1041/net/neoforged/neoforge/20.6.121-beta-pr-1041-connection-aware-stream-codec/mdk-pr1041.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[XFactHD]

Looks fine to me now. Have you tested whether connecting an NF server to a vanilla client and vice-versa and then interacting with something referencing effects such as potions works fine?

[RaymondBlaze]

Looks fine to me now. Have you tested whether connecting an NF server to a vanilla client and vice-versa and then interacting with something referencing effects such as potions works fine?

After the latest commit replacing StreamCodec#unit usage, potion with custom effect (containing custom cures on NF server) can be now used in both connections.

[Shadows-of-Fire]

Seems fine with me. If we encounter problems with the type-tightening from ByteBuf to RFBB on the mob effect instance codec, we can adjust it to downcast when available.

I suspect we will not encounter such issues, I don't envision anyone syncing specifically MobEffectInstance.Details outside of the Play phase, given that the only usage is in MobEffectInstance which requires RFBB.

[Technici4n]

Basically two suggestions. What do you think @Shadows-of-Fire and @XFactHD?