Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.4] Improved ModMismatchDisconnectedScreen and clientside handling of channel mismatches in general #1036

Merged

Conversation

RedstoneDubstep
Copy link
Contributor

This is a backport of the recently merged PR #672 to Minecraft version 1.20.4. There are no significant differences between this PR and the previously merged one, the only difference is the use of I18nExtension instead of FMLTranslations in ModMismatchDisconnectedScreen#init. I briefly tested this PR using a prod server (generated through a built server installer) and the changes appear to be working in 1.20.4 in the same way than in 1.20.6.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented May 28, 2024

  • Publish PR to GitHub Packages

Last commit published: 47b622e32a282a5af50c1cac13ec05da6ee8c67f.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1036' // https://github.com/neoforged/NeoForge/pull/1036
        url 'https://prmaven.neoforged.net/NeoForge/pr1036'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1036.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1036
cd NeoForge-pr1036
curl -L https://prmaven.neoforged.net/NeoForge/pr1036/net/neoforged/neoforge/20.4.237-pr-1036-1.20.4-mmds-improvements/mdk-pr1036.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@sciwhiz12 sciwhiz12 added enhancement New (or improvement to existing) feature or request backport Backport to an older version from a newer version 1.20.4 Targeted at Minecraft 1.20.4 labels Jun 7, 2024
Copy link
Member

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is nearly identical to its upstream counterpart, and a quick smoke test by running the production client shows no visible issues.

@sciwhiz12 sciwhiz12 merged commit 1d3161a into neoforged:1.20.4 Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.4 Targeted at Minecraft 1.20.4 backport Backport to an older version from a newer version enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants