Side-safety docs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technici4n
reviewed
Oct 16, 2023
sciwhiz12
requested changes
Oct 17, 2023
sciwhiz12
requested changes
Nov 12, 2023
There was a problem hiding this comment.
I think the explanation for the example code needs to be reworked. It has some inaccuracies, as I've noted in my review comments.
We probably ought to mention the quirk that JVMs are free to load classes lazily or eagerly (see JLS 17 § 12.3 "Linking of Classes and Interfaces") -- it's just that most if not all JVMs, including HotSpot, currently available prefer the lazy way. (Initialization, where static initializers run, is a different matter, and is clearly defined by JLS 17 § 12.4.1 "When Initialization Occurs".)
Co-authored-by: sciwhiz12 <[email protected]>
its too hard go look at the JLS or something idk
sciwhiz12
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds javadocs to
Distexplaining best practices with examples on how to prevent Dist-related classloading errors.Resurrection of MinecraftForge/MergeTool#8
Supports the goal of removing
DistExecutorand informing modders of how to properly guard code.