Translation support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support translations through resource bundles. By default the locale is set to the JVM's default locale (falling back to English), and once changed in the dropdown, it will be saved in the user's MC directory under (a hidden) `libraries/.neoforge_installer.properties` file
Last commit published: 68a5a4b83561aeafbfb4f7a0c4af207c4783d73c. PR PublishingThe artifacts published by this PR:Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #6' // https://github.com/neoforged/LegacyInstaller/pull/6
url 'https://prmaven.neoforged.net/LegacyInstaller/pr6'
content {
includeModule('net.neoforged', 'legacyinstaller')
}
}
} |
shartte
requested changes
Jan 9, 2024
src/main/java/net/minecraftforge/installer/ui/InstallerPanel.java
Outdated
Show resolved
Hide resolved
| props.put("language", locale.toLanguageTag()); | ||
| props.store(os, "NeoForge installer settings file"); | ||
| } | ||
| Files.setAttribute(settingsFile, "dos:hidden", true); |
shartte
reviewed
Jan 10, 2024
src/main/java/net/minecraftforge/installer/ui/InstallerPanel.java
Outdated
Show resolved
Hide resolved
shartte
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support translations through resource bundles.
By default the locale is set to the JVM's default locale (falling back to English), and once changed in the dropdown, it will be saved in the user's MC directory under (a hidden)
.neoforge_installer.propertiesfile.The translations will be done through Crowdin, the same way we have it set up for the NeoForge repository.