Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mixin #83

Closed
wants to merge 2 commits into from
Closed

Update mixin #83

wants to merge 2 commits into from

Conversation

Technici4n
Copy link
Member

Still a draft PR for a reason, the mixin update is not fully ready yet.

Mixin configs are now registered with an IMixinConfigSource which allows mixin to prefix injected callbacks with the ID of the source. For now, the logic is as follows:

  • For jars with a single mod, the ID is the modid.
  • For jars with multiple mods, the ID is the file name.

Known issues:

  • The mixin config source ID does not get propagated to the injected callback yet due to a bug in mixin.
  • Need to remove the snapshot maven once the Mixin is released.

@Technici4n Technici4n mentioned this pull request Jan 29, 2024
Closed
@sciwhiz12 sciwhiz12 added the enhancement New feature or request label Feb 11, 2024
@Technici4n Technici4n closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Technici4n @sciwhiz12