Deprecate the mandatory
dependency field and replace it with a type
field
#51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mandatory field is verbatim replaced by
type="required"
andtype="optional"
.Two more options are added:
incompatible
: prevents loading with the mod installeddiscouraged
: prompts the user a warning when the mod is installedA
reason
field is also added to be able to specify what leads to the incompatibility/conflict.Depends on neoforged/NeoForgeSPI#4
Something to consider later, when a rework of the loading code is done. The dependency graph should be able to distinguish between incompatible and normal dependencies for the sake of slightly improving the error message.