Implement dependency overrides #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minecraftschurli
requested changes
Dec 14, 2023
| return new OverridedModVersion(version, override); | ||
| } | ||
|
|
||
| public static class OverridedModVersion implements IModInfo.ModVersion { |
There was a problem hiding this comment.
Overrided is wrong, it should be Overridden
|
After some discussion with other maintainers, we have decided that the idea of this feature is not desirable for FML. (On top of the specific implementation being suboptimal). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote it in 30 minutes, didn't even test it (because I don't know how)
Inspired by Fabric