Add implementations of IModFileInfo#showAsDataPack for data pack grouping #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebemish
changed the title
|
neoforged/NeoForge#138 is now superseded by neoforged/NeoForge#367, but this PR is still needed for the latter |
Technici4n
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neoforged/NeoForge#138, in addition to changing how resource grouping works, sets up a system to group mod datapacks in addition to mod resource packs. This is useful for a number of reasons - largest on the list is that it is a simple way of ensuring that mod datapacks are sorted in mod loading order, not "order I installed the mod" order.
This PR implements a new API that that PR will need - namely, a flag in mod file info on whether mods should show a separate data pack, to go along with the equivalent one that already exists for resource packs. It goes along with neoforged/NeoForgeSPI#1, which adds the actual API, which this PR then implements; as such, it's not going to build without that PR