Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new option to strip final from parameters #6

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Apr 10, 2024

Mojang now publishes parameter metadata, which retains the final attribute they use in their source.

This will cause conflicts in our patches and we will have to patch method signature sources to change the value of parameters inside of method bodies. Because of that, this adds a new option to strip the final attribute from parameters.

@Technici4n Technici4n merged commit 1cbb9a3 into main Apr 10, 2024
1 check passed
@Technici4n Technici4n deleted the add-unfinal-params branch April 10, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants