Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Completion Blocked by incomplete Item #5029

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hexh250786313
Copy link
Contributor

Should fix #5028.

This pull request is still under testing.

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.51%. Comparing base (ba3c0a9) to head (7adbccb).

Files Patch % Lines
src/completion/pum.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5029      +/-   ##
==========================================
- Coverage   98.51%   98.51%   -0.01%     
==========================================
  Files         273      273              
  Lines       26072    26068       -4     
  Branches     5389     5388       -1     
==========================================
- Hits        25684    25680       -4     
+ Misses        228      226       -2     
- Partials      160      162       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hexh250786313 hexh250786313 force-pushed the fix/completion_blocked_by_incomplete branch from 8cfa2dd to 91d3c24 Compare June 2, 2024 12:25
@hexh250786313
Copy link
Contributor Author

if (!noselect) {
selectedIndex = selectedIndex == -1 ? 0 : selectedIndex
} else {

It defaults to setting the first item as the selected state. For incompletion items with high priority values, they become the top item every time after refresh, causing them to be selected by default even if preselect is not configured. I must say, this behavior is a bit annoying. Need to fix.

@hexh250786313 hexh250786313 marked this pull request as draft June 14, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asynchronous Completion for isIncomplete Items in coc.nvim
2 participants