Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeitwerk migration + activesupport 7.1 support #1703

Closed
wants to merge 14 commits into from
Closed

Conversation

klobuczek
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c2f35a) 93.55% compared to head (79c8637) 93.12%.
Report is 1 commits behind head on master.

❗ Current head 79c8637 differs from pull request most recent head 3bf8aa8. Consider uploading reports for the commit 3bf8aa8 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1703      +/-   ##
==========================================
- Coverage   93.55%   93.12%   -0.44%     
==========================================
  Files         128      128              
  Lines        5926     5700     -226     
==========================================
- Hits         5544     5308     -236     
- Misses        382      392      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chytreg
Copy link
Contributor

chytreg commented Nov 8, 2023

This is what I am waiting for :) Will it be released in the near future?

* corrected gemfile generation

* loaded active_graph in railtie

* removed commented code from gemfile
@klobuczek
Copy link
Member Author

@chytreg sorry, we are trying to release the branch this week

klobuczek and others added 4 commits December 28, 2023 14:21
* generator file structure revert

* removed extra scope

* corrected generators spec

* ignored railtie and rails dir

* corrected railtie spec

* moved rails specific loading to railtie

* corrected spec and load order

* code cleanup
@klobuczek
Copy link
Member Author

@chytreg please have a look at 11.5.0.beta.1 and let us know if you find any issues.

@klobuczek
Copy link
Member Author

PR already merged branch 11

@klobuczek klobuczek closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants