-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow database names to start with a digit #1952
base: dev
Are you sure you want to change the base?
Conversation
10b2f8b
to
8728ba8
Compare
Updated to add a note to say which release this was changed. |
modules/ROOT/pages/database-administration/standard-databases/naming-databases.adoc
Outdated
Show resolved
Hide resolved
@@ -812,7 +812,8 @@ m|+++0+++ | |||
|Description | |||
a|Names of the databases allowed on this server; all others are denied. Empty means all are allowed. This configuration can be overridden when enabling the server or altered at runtime without changing this setting. Exclusive with `server.initial_denied_databases`. | |||
|Valid values | |||
a|A comma-separated set where each element is a valid database name containing only alphabetic characters, numbers, dots, and dashes with a length between 3 and 63 characters, starting with an alphabetic character but not with the name `system`. | |||
a|A comma-separated set where each element is a valid database name. | |||
Database naming rules are described in xref:database-administration/standard-databases/naming-databases.adoc[Naming rules for databases] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a build error regarding this file, I guess something with this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it seems like they validate the config descriptions against the database, so I can't do this:
== Docs ==
A valid database name. Database naming rules are described in Naming rules for databases
== Neo4j ==
A valid database name containing only alphabetic characters, numbers, dots, and dashes with a length between 3 and 63 characters, starting with an alphabetic character but not with the name system.
I guess I need to go back into the monorepo and update them all there 😮💨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually that doesn't make much sense to have "from version ..." in the database core repo, since that always knows what version it is. Maybe I just need to add the digits there and leave it at that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add labels in the docs description as labels are ignored by the test if by "from version .." you mean when this change is introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cf76db2
to
e5fb5e0
Compare
modules/ROOT/pages/database-administration/standard-databases/naming-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/standard-databases/naming-databases.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small suggestion, otherwise looks good.
We have relaxed the database naming rules to allow a database name to start with a digit. Update docs to reflect this.
…naming-databases.adoc Co-authored-by: Reneta Popova <[email protected]>
70b19f6
to
e20cb3a
Compare
This PR includes documentation updates Updated pages: |
We have relaxed the database naming rules to allow a database name to start with a digit. Update docs to reflect this.
See also https://github.com/neo-technology/neo4j/pull/28262