Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug with semantic analysis not working in Firefox #303

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ncordon
Copy link
Collaborator

@ncordon ncordon commented Nov 28, 2024

If I modify semanticAnalysisWrapper.ts to be:

export function wrappedSemanticAnalysis(
  query: string,
  dbSchema: DbSchema,
): SemanticAnalysisResult {
  try {
    let semanticErrorsResult = undefined;

    updateSignatureResolver({
      procedures: Object.values(dbSchema.procedures ?? {}),
      functions: Object.values(dbSchema.functions ?? {}),
    });
    semanticAnalysis([query], (a) => {
      semanticErrorsResult = a;
    });
    /********************************
     This console log was not here
    ********************************/
    console.log(semanticErrorsResult)
    const errors: SemanticAnalysisElementNoSeverity[] =
      semanticErrorsResult.errors;

we could see things were blowing the stack in Firefox (but not always):

Adding a warm up step to the semantic analysis seems to solve the issue. I can reproduce with Firefox but not with Playwright 😢

Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: 782db9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ncordon ncordon force-pushed the semantic-analysis-firefox branch 2 times, most recently from 675aa05 to b59ec73 Compare November 29, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant