Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3Hl7fTsQ] Dev fix misleading name column #675

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

gem-neo4j
Copy link
Contributor

The name column was different between these 2 equivalent procedures, and wasn't even actually giving the name of the constraint/index. So this makes it more consistent with SHOW CONSTRAINTS/INDEXES

@gem-neo4j gem-neo4j force-pushed the dev_fix_misleading_name_column branch from b7097c9 to 32659a5 Compare October 28, 2024 08:37
@gem-neo4j gem-neo4j changed the title Dev fix misleading name column [3Hl7fTsQ] Dev fix misleading name column Oct 28, 2024
@gem-neo4j gem-neo4j force-pushed the dev_fix_misleading_name_column branch from 32659a5 to 5db4bb4 Compare October 28, 2024 14:15
Copy link
Contributor

@loveleif loveleif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gem-neo4j gem-neo4j force-pushed the dev_fix_misleading_name_column branch from 5db4bb4 to 2b3d99b Compare October 30, 2024 12:16
@gem-neo4j
Copy link
Contributor Author

@loveleif in order to fix a failing test I had to make quite a few changes, when you have time can you review the second commit? :)

@gem-neo4j gem-neo4j merged commit f0c8172 into dev Nov 6, 2024
11 checks passed
@gem-neo4j gem-neo4j deleted the dev_fix_misleading_name_column branch November 6, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants