[G9u7OAg9] Ignore check for optimizations if the format is CSV #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
force-pushed
the
dev_dont_error_for_csv_config_missing_optimizations
branch
2 times, most recently
from
b94dfbf to
fa04d10
Compare
ncordon
reviewed
Nov 29, 2023
Comment on lines
+177
to
181
| if (!OptimizationType.NONE.equals(this.optimizationType) && this.unwindBatchSize > this.batchSize | ||
| && !ExportFormat.CSV.equals(this.format)) { | ||
| throw new RuntimeException("`unwindBatchSize` must be <= `batchSize`, but got [unwindBatchSize:" | ||
| + unwindBatchSize + ", batchSize:" + batchSize + "]"); | ||
| } |
There was a problem hiding this comment.
I'd say this message is not good. It's better to split into another condition where we throw a specific exception for the case where we've passed an optimization and a csv format?
There was a problem hiding this comment.
The only problem with erroring when someone passes an optimization format and CSV is that it was required before due to this bug, so erroring on that would be breaking for everyone using CSV 😅
ncordon
approved these changes
Dec 4, 2023
gem-neo4j
force-pushed
the
dev_dont_error_for_csv_config_missing_optimizations
branch
from
fa04d10 to
0a3eb35
Compare
gem-neo4j
deleted the
dev_dont_error_for_csv_config_missing_optimizations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSV export can't use optimizations, so the check that it is correct is not very useful. In general we should probably clean up these configs as it is quite messy having all of them, but that requires an investigation into which procedure needs what 👀