Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOID] Remove explicit netty dependency #515

Merged
merged 1 commit into from
Oct 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions LICENSES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Apache-2.0
commons-configuration2-2.9.0.jar
commons-csv-1.9.0.jar
commons-daemon-1.0.13.jar
commons-io-2.13.0.jar
commons-io-2.14.0.jar
commons-lang3-3.13.0.jar
commons-logging-1.2.jar
commons-math3-3.6.1.jar
Expand Down Expand Up @@ -446,7 +446,7 @@ BSD-2-Clause
jline-3.9.0.jar
jsch-0.1.55.jar
stax2-api-4.2.1.jar
zstd-jni-1.5.5-5.jar
zstd-jni-1.5.5-6.jar
------------------------------------------------------------------------------

Copyright <year> <copyright holder>
Expand Down Expand Up @@ -475,11 +475,11 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
------------------------------------------------------------------------------
BSD-3-Clause
asm-9.3.jar
asm-9.5.jar
asm-analysis-9.5.jar
asm-9.6.jar
asm-analysis-9.6.jar
asm-commons-5.0.3.jar
asm-tree-9.5.jar
asm-util-9.5.jar
asm-tree-9.6.jar
asm-util-9.6.jar
hamcrest-2.2.jar
hamcrest-core-2.2.jar
hamcrest-library-2.2.jar
Expand Down
12 changes: 6 additions & 6 deletions NOTICE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Apache-2.0
commons-configuration2-2.9.0.jar
commons-csv-1.9.0.jar
commons-daemon-1.0.13.jar
commons-io-2.13.0.jar
commons-io-2.14.0.jar
commons-lang3-3.13.0.jar
commons-logging-1.2.jar
commons-math3-3.6.1.jar
Expand Down Expand Up @@ -278,15 +278,15 @@ BSD-2-Clause
jline-3.9.0.jar
jsch-0.1.55.jar
stax2-api-4.2.1.jar
zstd-jni-1.5.5-5.jar
zstd-jni-1.5.5-6.jar

BSD-3-Clause
asm-9.3.jar
asm-9.5.jar
asm-analysis-9.5.jar
asm-9.6.jar
asm-analysis-9.6.jar
asm-commons-5.0.3.jar
asm-tree-9.5.jar
asm-util-9.5.jar
asm-tree-9.6.jar
asm-util-9.6.jar
hamcrest-2.2.jar
hamcrest-core-2.2.jar
hamcrest-library-2.2.jar
Expand Down
6 changes: 1 addition & 5 deletions core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,11 @@ dependencies {
exclude group: 'com.fasterxml.jackson.core', module: 'jackson-annotations'
exclude group: 'com.fasterxml.jackson.core', module: 'jackson-databind'
exclude group: 'io.netty', module: 'netty-common'
exclude group: 'io.netty', module: 'netty-buffer'
}

implementation group: 'org.apache.arrow', name: 'arrow-vector', version: '13.0.0', arrowExclusions
implementation group: 'org.apache.arrow', name: 'arrow-memory-netty', version: '13.0.0', arrowExclusions
implementation group: 'io.netty', name: 'netty-buffer', {
version {
strictly '4.1.99.Final'
}
}

// These will be dependencies not packaged with the .jar
// They need to be provided either through the database or in an extra .jar
Expand Down
278 changes: 0 additions & 278 deletions core/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java

This file was deleted.

1 change: 0 additions & 1 deletion licenses-source-header.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ allprojects { proj ->
java = 'SLASHSTAR_STYLE'
}
// exclude 'test/resources/**'
exclude '**/PooledByteBufAllocatorL.java'
include '**/*.java'
}
tasks.check.dependsOn tasks.license
Expand Down