[uSvFQccG] Make ExportCypherTest more robust. #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things like the order in UNWIND lists and the exact ids could vary, which is not a problem for the functionality but cause flakiness of the test.
gem-neo4j
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
I think this is a good way to deal with it :) Maybe make a cleanup card somewhere in APOC trello that points here so if we do get a flaky test card for another area we have links pointing to this solution?
Another thought, and I know this wasn't to do with this PR, but I find tests naming ids of github issues hard to understand, would be nice if we either had a comment explaining the original issue or a more explanatory name, nothing for you to do here, just a rant :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things like the order in UNWIND lists and the exact ids could vary, which is not a problem for the functionality but cause flakiness of the test.
I focused on the test that was marked as flaky, but this could be done for more of the export tests as a follow-up cleanup/remove risk of flakiness task if we like to.