-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cards #288
base: master
Are you sure you want to change the base?
Fix cards #288
Conversation
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
preview-src/docs-hub.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have cards that are selectable, but which also contain links. The first two cards on this page - the card shouldn't be clickable because it has two links and those are what you need to click on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you separate the types of cards in the .adoc file? Like, the styling keeps on being applied after one card. I tried putting the card into --
separators, but it didn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be possible now to add the role before the heading ie
[.selectable]
=== Neo4j Data Importer
src/css/docs-ndl.css
Outdated
box-sizing: border-box; | ||
padding-top: 0; | ||
margin-top: auto; | ||
font-size: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended to make the link invisible?
I don't think a card that is selectable should have a visible link, so so we can just use something like
body.docs-ndl .cards.selectable .sect2 .paragraph.link {
display:none;
}
to hide all paragraphs that have the .link
role in cards that have the .selectable
role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it doesn't work without the .hide subclass. If I use your suggestion, it hides the links from the non-selectable cards too, even if I keep the following lines intact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fixed in the css now 👍🏻
No description provided.