Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade kafka client #620

Merged
merged 7 commits into from
Mar 19, 2024

Conversation

venikkin
Copy link
Contributor

Fixes Kafka client security alert

Proposed Changes (Mandatory)

  • update Kafka client dependency version
  • remove dead code

@venikkin venikkin marked this pull request as ready for review March 15, 2024 16:06
@venikkin venikkin requested a review from a team as a code owner March 15, 2024 16:06
@venikkin
Copy link
Contributor Author

Fix neo4j-streams CVE

pom.xml Outdated
<kotlin.version>1.9.20</kotlin.version>
<kotlin.coroutines.version>1.7.3</kotlin.coroutines.version>
<neo4j.version>4.4.27</neo4j.version>
<kafka.version>2.6.3</kafka.version>
<kafka.version>3.7.0</kafka.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in #619.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.4 is the lowest version containing the fix. As we discussed used it.

@venikkin venikkin requested a review from ali-ince March 18, 2024 09:43
pom.xml Outdated
@@ -49,10 +49,12 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<java.version>11</java.version>
<java.version>11</java.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting it. Fixed.

@venikkin venikkin requested a review from fbiville March 19, 2024 09:27
@venikkin venikkin merged commit 041a936 into neo4j-contrib:5.0 Mar 19, 2024
4 checks passed
@venikkin venikkin deleted the 5.0-upgrade-kafka-client branch March 19, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants