fixes #537: Kafka sink connector does not work with CUD ingestion strategy and Avro format data #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-ince
reviewed
Aug 29, 2023
| @@ -1351,6 +1353,54 @@ class Neo4jSinkTaskTest { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| fun `should successfully parse nested timestamps`() { | |||
There was a problem hiding this comment.
is this just timestamps, or more general sub-maps?
There was a problem hiding this comment.
is general sub-maps
| } | ||
|
|
||
| @Test | ||
| fun `should be able to process a CUD format AVRO structure`() { |
There was a problem hiding this comment.
should we also include a test for relationship CUD format?
…ingestion strategy and Avro format data
fbiville
pushed a commit
to neo4j/neo4j-kafka-connector
that referenced
this pull request
Nov 3, 2023
Fix Kafka sink connector to work with CUD ingestion strategy and Avro format data. See neo4j-contrib/neo4j-streams#582
fbiville
pushed a commit
to neo4j/neo4j-kafka-connector
that referenced
this pull request
Nov 3, 2023
Fix Kafka sink connector to work with CUD ingestion strategy and Avro format data. See neo4j-contrib/neo4j-streams#582
fbiville
pushed a commit
to neo4j/neo4j-kafka-connector
that referenced
this pull request
Nov 3, 2023
Fix Kafka sink connector to work with CUD ingestion strategy and Avro format data. See neo4j-contrib/neo4j-streams#582
fbiville
pushed a commit
to neo4j/neo4j-kafka-connector
that referenced
this pull request
Nov 3, 2023
Fix Kafka sink connector to work with CUD ingestion strategy and Avro format data. See neo4j-contrib/neo4j-streams#582
ali-ince
pushed a commit
to neo4j/neo4j-kafka-connector
that referenced
this pull request
Nov 3, 2023
Fix Kafka sink connector to work with CUD ingestion strategy and Avro format data. See neo4j-contrib/neo4j-streams#582 Co-authored-by: Andrea Santurbano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #537
The bug was related to the fact that the strategy expects a Map<String, Any?> (with the raw values) instead it gets a Map<String, Value>. I changed the converter in order to return Map<String, Any?> (with the raw values)
Proposed Changes (Mandatory)
A brief list of proposed changes in order to fix the issue: