Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOID] Apoc Config import fix #3715

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

gem-neo4j
Copy link
Contributor

This was a mistake made when backporting to 4.4, the 5.x version was correct but must have auto imported googles one over Neo's :| This means that if a user tries to use expand config with APOC installed, there is a missing dependency, the workaround is to use just pop the google jar into plugins, but this is the real fix :)

@gem-neo4j gem-neo4j added 4.4 team-cypher-surface Cypher Surface team should review the PR labels Aug 9, 2023
Copy link
Contributor

@ncordon ncordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would have been caught by an integration test. Should we add one / modify one so it tries to use command expansion?

@gem-neo4j
Copy link
Contributor Author

Yeah, that sounds good, will do that :)

Copy link
Contributor

@ncordon ncordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to skip the test as it was quite tricky to add it

@gem-neo4j gem-neo4j merged commit 67ff7b1 into 4.4 Aug 15, 2023
11 checks passed
@gem-neo4j gem-neo4j deleted the 4.4_fix_command_expansion_dependency branch August 15, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 team-cypher-surface Cypher Surface team should review the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants