-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve no suitable method found for register #3666
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
force-pushed
the
solve-no-suitable-method-CypherProceduresHandler
branch
7 times, most recently
from
July 18, 2023 13:44
6036f3f
to
7c1e171
Compare
vga91
force-pushed
the
solve-no-suitable-method-CypherProceduresHandler
branch
8 times, most recently
from
July 28, 2023 09:43
1e667ac
to
cc9e00e
Compare
vga91
force-pushed
the
solve-no-suitable-method-CypherProceduresHandler
branch
4 times, most recently
from
August 4, 2023 06:44
74e901c
to
edd0616
Compare
This was referenced Aug 21, 2023
Merged
vga91
force-pushed
the
solve-no-suitable-method-CypherProceduresHandler
branch
2 times, most recently
from
August 22, 2023 09:17
1f31beb
to
a9824aa
Compare
* Fix various 5.11 build errors * small comment changes * excluded some hadoop deps to avoid conflict with neo4j 5.11 lib deps * Fix failing path traversal CI tests * Add explicit mockito test dependency * Generalized html with js error - it depends on the driver version * added parquet procs to extended.txt * wip - include only StartupExtendedTest * restored build.gradle * Added Extended annotation * Added Extended annotation * Added Extended annotation * Updated com.diffplug.spotless version * restore spotless * Fix custom proc with homonyms
vga91
force-pushed
the
solve-no-suitable-method-CypherProceduresHandler
branch
from
August 24, 2023 07:59
f73db68
to
b63ba5d
Compare
vga91
added
the
cherry-picked
This PR has been cherry-picked to the other active branches
label
Aug 24, 2023
The CodeQL job failed will be fixed in another pr |
recrwplay
pushed a commit
to recrwplay/neo4j-apoc-procedures
that referenced
this pull request
Aug 31, 2023
* Solve no suitable method found for register * Re-register homonym fun/proc * lightened tests * lightened tests * try include only Startup * ignore provisionally startup with extra-deps tests * restore ExtendedTestContainerUtil * small comment changes * excluded some hadoop deps to avoid conflict with neo4j 5.11 lib deps * Fix various 5.11 build errors (neo4j-contrib#3722) * Fix various 5.11 build errors * small comment changes * excluded some hadoop deps to avoid conflict with neo4j 5.11 lib deps * Fix failing path traversal CI tests * Add explicit mockito test dependency * Generalized html with js error - it depends on the driver version * added parquet procs to extended.txt * wip - include only StartupExtendedTest * restored build.gradle * Added Extended annotation * Added Extended annotation * Added Extended annotation * Updated com.diffplug.spotless version * restore spotless * Fix custom proc with homonyms * Removed unused imports * Fix CypherEnterpriseExtendedTest similarly to 5.11 one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked
This PR has been cherry-picked to the other active branches
dev
do_not_merge
extended-functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from here: Fix various 5.11 build errors #3722
Removed some unused imports
StartupExtendedTest conflict
Excluded some hadoop sub-dependencies which are included in 5.11 lib as well, to prevent conflict exception like here.
Ignored StartupExtendedTest, for the moment, because of 5.11.0 conflict exception. Added a card so solve it: https://trello.com/c/woAYoqwZ/72-de-ignoreCustom procedure error
Changed
globalProceduresRegistry.register(<Callable>, true)
(which allowed ) toglobalProceduresRegistry.register(<Callable>)
and addedglobalProceduresRegistry.unregister(signature.name());
in order to prevent
"Unable to register function/procedure, because the name
%sis already in use "
error.This happens because of this neo4j change
CI Error 1.
See https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/5585556876/jobs/10208445586?pr=3605#step:6:199
Added a card to check for a better resolution: https://trello.com/c/88y38wtZ/64-check-for-better-resolution
Custom procedure 2nd error
Removed
globalProceduresRegistry.lookupComponentProvider(Transaction.class, true);
andtransactionComponentFunction.apply(ctx);
,and added
Transaction tx = ctx.transaction();
insteadCI Error 2.
See https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/5622346308/job/15234835763?pr=3666#step:6:203