Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve no suitable method found for register #3666

Merged
merged 12 commits into from
Aug 24, 2023

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Jul 18, 2023



StartupExtendedTest conflict

Excluded some hadoop sub-dependencies which are included in 5.11 lib as well, to prevent conflict exception like here.

Ignored StartupExtendedTest, for the moment, because of 5.11.0 conflict exception. Added a card so solve it: https://trello.com/c/woAYoqwZ/72-de-ignore


Custom procedure error

Changed globalProceduresRegistry.register(<Callable>, true) (which allowed ) to globalProceduresRegistry.register(<Callable>) and added globalProceduresRegistry.unregister(signature.name());
in order to prevent "Unable to register function/procedure, because the name %s is already in use " error.
This happens because of this neo4j change

CI Error 1.
See https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/5585556876/jobs/10208445586?pr=3605#step:6:199

(actual and formal argument lists differ in length)
/home/runner/work/neo4j-apoc-procedures/neo4j-apoc-procedures/extended/src/main/java/apoc/custom/CypherProceduresHandler.java:371: error: no suitable method found for register(<anonymous BasicUserFunction>,boolean)
            globalProceduresRegistry.register(new CallableUserFunction.BasicUserFunction(signature) {

Added a card to check for a better resolution: https://trello.com/c/88y38wtZ/64-check-for-better-resolution


Custom procedure 2nd error

Removed globalProceduresRegistry.lookupComponentProvider(Transaction.class, true); and transactionComponentFunction.apply(ctx); ,
and added Transaction tx = ctx.transaction(); instead

CI Error 2.
See https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/5622346308/job/15234835763?pr=3666#step:6:203

/home/runner/work/neo4j-apoc-procedures/neo4j-apoc-procedures/extended/src/main/java/apoc/custom/CypherProceduresHandler.java:117: error: cannot find symbol
        transactionComponentFunction = globalProceduresRegistry.lookupComponentProvider(Transaction.class, true);
                                                               ^
  symbol:   method lookupComponentProvider(Class<Transaction>,boolean)

@vga91 vga91 force-pushed the solve-no-suitable-method-CypherProceduresHandler branch 7 times, most recently from 6036f3f to 7c1e171 Compare July 18, 2023 13:44
@vga91 vga91 force-pushed the solve-no-suitable-method-CypherProceduresHandler branch 8 times, most recently from 1e667ac to cc9e00e Compare July 28, 2023 09:43
@vga91 vga91 force-pushed the solve-no-suitable-method-CypherProceduresHandler branch 4 times, most recently from 74e901c to edd0616 Compare August 4, 2023 06:44
This was referenced Aug 21, 2023
@vga91 vga91 force-pushed the solve-no-suitable-method-CypherProceduresHandler branch 2 times, most recently from 1f31beb to a9824aa Compare August 22, 2023 09:17
* Fix various 5.11 build errors

* small comment changes

* excluded some hadoop deps to avoid conflict with neo4j 5.11 lib deps

* Fix failing path traversal CI tests

* Add explicit mockito test dependency

* Generalized html with js error - it depends on the driver version

* added parquet procs to extended.txt

* wip - include only StartupExtendedTest

* restored build.gradle

* Added Extended annotation

* Added Extended annotation

* Added Extended annotation

* Updated com.diffplug.spotless version

* restore spotless

* Fix custom proc with homonyms
@vga91 vga91 force-pushed the solve-no-suitable-method-CypherProceduresHandler branch from f73db68 to b63ba5d Compare August 24, 2023 07:59
@vga91 vga91 added the cherry-picked This PR has been cherry-picked to the other active branches label Aug 24, 2023
@vga91
Copy link
Collaborator Author

vga91 commented Aug 24, 2023

The CodeQL job failed will be fixed in another pr

@vga91 vga91 merged commit 1c00e23 into dev Aug 24, 2023
3 of 4 checks passed
@vga91 vga91 deleted the solve-no-suitable-method-CypherProceduresHandler branch August 24, 2023 14:11
recrwplay pushed a commit to recrwplay/neo4j-apoc-procedures that referenced this pull request Aug 31, 2023
* Solve no suitable method found for register

* Re-register homonym fun/proc

* lightened tests

* lightened tests

* try include only Startup

* ignore provisionally startup with extra-deps tests

* restore ExtendedTestContainerUtil

* small comment changes

* excluded some hadoop deps to avoid conflict with neo4j 5.11 lib deps

* Fix various 5.11 build errors (neo4j-contrib#3722)

* Fix various 5.11 build errors

* small comment changes

* excluded some hadoop deps to avoid conflict with neo4j 5.11 lib deps

* Fix failing path traversal CI tests

* Add explicit mockito test dependency

* Generalized html with js error - it depends on the driver version

* added parquet procs to extended.txt

* wip - include only StartupExtendedTest

* restored build.gradle

* Added Extended annotation

* Added Extended annotation

* Added Extended annotation

* Updated com.diffplug.spotless version

* restore spotless

* Fix custom proc with homonyms

* Removed unused imports

* Fix CypherEnterpriseExtendedTest similarly to 5.11 one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked This PR has been cherry-picked to the other active branches dev do_not_merge extended-functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant