fix Biginteger default. #1242
fix Biginteger default. #1242
Conversation
|
In what case do we utilize BigInteger default value as null? |
Well, i might not be clear, default value of BigInteger is 0, but it will not be assigned automatically when we define a BigInteger. I have tried, C# syntax analyer wont allow you to use an uninitialized BigInteger actually, it will show you an error.
|
|
I think enabling nullable is enough (in PR 1214) |
I personally dont think we should enable nullable in contract, not really being much help to contract but introduces many complex work in compiler.... but since we already have it, so, lets complete 1214 then. |
Nullable simply gives more hints to the user, and does not affect the compiler. If nullable is false, everything can be silently null, being more dangerous. |
Not in this pr, i mean compiler level nullable support that we already have, nullable value requires extra checks and increases the complexity. |
|
In this PR we are trying to mark BigInteger declared in method. However, if we apply this methodology, then for all types of variables declared in methods, they are all null, and all have to be checked with many efforts. Thus using in csproj brings more efficient and accurate checks, for free. |
| { | ||
| // The default BigInteger is null. | ||
| // But object creation will assign BigInteger a default value | ||
| if (fields[i].Type.Name == nameof(BigInteger)) |
There was a problem hiding this comment.
Its better to check types with namespace
This pr fix the BigInteger default value.
When we define a BigInteger, it will not be assigned a default value like int, but it will remain as null.
but when it is defined in a class/struct, the defualt constructor of of class/struct will assign it a default value.