BREAKING! Make SELECT clause columns optional

nene · Nov 8, 2023 · 824386c · 824386c
1 parent 0f98a6d
commit 824386c
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 3 deletions.
diff --git a/src/cst/Select.ts b/src/cst/Select.ts
@@ -136,7 +136,7 @@ export interface SelectClause extends BaseNode {
  distinctKw?: Keyword<"ALL" | "DISTINCT" | "DISTINCTROW">;
  hints: MysqlHint[];
  asStructOrValueKw?: [Keyword<"AS">, Keyword<"STRUCT" | "VALUE">];
- columns: ListExpr<
+ columns?: ListExpr<
  AllColumns | ExceptColumns | ReplaceColumns | Expr | Alias<Expr> | Empty
  >;
 }

diff --git a/test/select/select.test.ts b/test/select/select.test.ts
@@ -90,6 +90,28 @@ describe("select", () => {
  test(`SELECT FROM tbl;`);
  test(`SELECT;`);
  });
+
+ it("parses empty select into undefined columns field", () => {
+ expect(parseStmt(`SELECT`)).toMatchInlineSnapshot(`
+ {
+ "clauses": [
+ {
+ "asStructOrValueKw": undefined,
+ "columns": undefined,
+ "distinctKw": undefined,
+ "hints": [],
+ "selectKw": {
+ "name": "SELECT",
+ "text": "SELECT",
+ "type": "keyword",
+ },
+ "type": "select_clause",
+ },
+ ],
+ "type": "select_stmt",
+ }
+ `);
+ });
  });
 
  dialect("bigquery", () => {

diff --git a/test/test_utils.ts b/test/test_utils.ts
@@ -101,9 +101,9 @@ export function parseExpr(
  if (clause.type !== "select_clause") {
  throw new Error(`Expected select_clause, instead got ${clause.type}`);
  }
- if (clause.columns.items.length !== 1) {
+ if (clause.columns?.items.length !== 1) {
  throw new Error(
- `Expected 1 column, instead got ${clause.columns.items.length}`
+ `Expected 1 column, instead got ${clause.columns?.items.length ?? 0}`
  );
  }
  const result = clause.columns.items[0];