Support FUNC/PROC default parameter values in PostgreSQL

nene · Jan 26, 2024 · 17a2f95 · 17a2f95
1 parent 20c2470
commit 17a2f95
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 3 deletions.
diff --git a/src/cst/Function.ts b/src/cst/Function.ts
@@ -16,6 +16,7 @@ import { BlockStmt } from "./ProceduralLanguage";
 export type AllFunctionNodes =
  | AllFunctionStatements
  | FunctionParam
+ | FunctionParamDefault
  | ReturnClause;
 
 export type AllFunctionStatements = CreateFunctionStmt | DropFunctionStmt;
@@ -39,6 +40,13 @@ export interface FunctionParam extends BaseNode {
  mode?: Keyword<"IN" | "OUT" | "INOUT" | "VARIADIC">;
  name?: Identifier;
  dataType: DataType;
+ default?: FunctionParamDefault;
+}
+
+export interface FunctionParamDefault extends BaseNode {
+ type: "function_param_default";
+ operator: Keyword<"DEFAULT"> | "=";
+ expr: Expr;
 }
 
 type CreateFunctionClause =

diff --git a/src/parser.pegjs b/src/parser.pegjs
@@ -2930,19 +2930,30 @@ procedure_param
  dataType: type,
  });
  }
- / &postgres mode:((INOUT / IN / OUT / VARIADIC) __)? name:(ident __) type:data_type {
+ / &postgres mode:((INOUT / IN / OUT / VARIADIC) __)? name:(ident __) type:data_type def:(__ function_param_default)? {
  return loc({
  type: "function_param",
  mode: read(mode),
  name: read(name),
  dataType: type,
+ default: read(def),
  });
  }
- / &postgres mode:((INOUT / IN / OUT / VARIADIC) __)? type:data_type {
+ / &postgres mode:((INOUT / IN / OUT / VARIADIC) __)? type:data_type def:(__ function_param_default)? {
  return loc({
  type: "function_param",
  mode: read(mode),
  dataType: type,
+ default: read(def),
+ });
+ }
+
+function_param_default
+ = operator:(DEFAULT / "=") expr:(__ expr) {
+ return loc({
+ type: "function_param_default",
+ operator,
+ expr: read(expr),
  });
  }
 

diff --git a/src/showNode/function.ts b/src/showNode/function.ts
@@ -15,7 +15,9 @@ export const functionMap: FullTransformMap<string, AllFunctionNodes> = {
  node.params,
  node.clauses,
  ]),
- function_param: (node) => show([node.mode, node.name, node.dataType]),
+ function_param: (node) =>
+ show([node.mode, node.name, node.dataType, node.default]),
+ function_param_default: (node) => show([node.operator, node.expr]),
  return_clause: (node) => show([node.returnKw, node.expr]),
  drop_function_stmt: (node) =>
  show([

diff --git a/test/ddl/function.test.ts b/test/ddl/function.test.ts
@@ -30,6 +30,10 @@ describe("function", () => {
  AS $$ SELECT ARRAY[$1, $2]; $$
  `);
  });
+
+ it("supports default values", () => {
+ testWc(`CREATE FUNCTION foo(IN x INT = 1, y INT DEFAULT 2, INT = 3) ${body}`);
+ });
  });
 
  it("supports OR REPLACE", () => {

diff --git a/test/ddl/procedure.test.ts b/test/ddl/procedure.test.ts
@@ -59,6 +59,10 @@ describe("procedure", () => {
  AS $$ SELECT $1, $2; $$
  `);
  });
+
+ it("supports default values", () => {
+ testWc(`CREATE PROCEDURE foo(x INT = 1, OUT y INT DEFAULT 2) ${BEGIN} SELECT 1; END`);
+ });
  });
 
  it("supports OR REPLACE", () => {