Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward preprocessor definitions to the remote compiler. #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Forward preprocessor definitions to the remote compiler. #42

wants to merge 1 commit into from

Commits on Jun 13, 2021

  1. Forward preprocessor definitions to the remote compiler. 

    When doing partial local preprocessing, a remote clang compilation
still needs the preprocessor definitions from the command line so
that the remaining preprocessing can be performed correctly. Partial
preprocessing is necessary to prevent the remote compiler issuing
spurious warnings from macro expansion that would be suppressed in
a local compilation.

This means when spawning a compilation, we should always use either
`LocalArgs` or `RemoteArgs`, and the need to separately preserve
unknown arguments and conditionally restore preprocessor definitions
goes away.

This updates nelhage#37.
    @jpeach
    jpeach committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    9da6bfe View commit details
    Browse the repository at this point in the history