-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/submission diagram update #88
Conversation
fe9d7b9
to
d43c07b
Compare
29139bb
to
92cd3c9
Compare
7b366a3
to
b297568
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements! The database and submission pipeline mermaid diagrams were quite tiny, and since they are not pictures, they cant easily be mangnified in a separate viewer. Firefox zoom (ctrl-+) only enlarge the text of the page and not really the diagram text (or the effect is not really that noticable).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The only problem is as @kjellp mentioned that the diagram details can be very hard to read.
Describe the pull request:
Changes made:
Related issues:
Additional information:
Release note:
Documentation change:
Mentions:
@aaperis apologies about taking the task related to db, but i found this: https://github.com/KarnerTh/mermerd that helped me generate the diagram. Still feel free to make changes