Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework of contribution guide section #101

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

aaperis
Copy link
Contributor

@aaperis aaperis commented Dec 19, 2023

Describe the pull request:

  • Documentation change

Pull request long description:

The text is partially rephrased at places, links were updated and a separation between contributing to the codebase repo and the handbook repo was made.

Additional information:

I noticed that there are some Issue templates here that seem somewhat obsolete. Do we keep them? If yes, I can add a mention to these cases as well.

@aaperis aaperis requested a review from a team December 19, 2023 22:26
@blankdots
Copy link
Contributor

I noticed that there are some Issue templates here that seem somewhat obsolete. Do we keep them? If yes, I can add a mention to these cases as well.

those don't seem relevant now, except the new question.

also we might want to adjust the Pull request template to https://github.com/neicnordic/sensitive-data-archive/blob/main/.github/PULL_REQUEST_TEMPLATE.md as it is simpler

blankdots
blankdots previously approved these changes Dec 20, 2023
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion, otherwise looks pretty good.

I am fine including template changes in this PR or another one

docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Stefan Negru <[email protected]>
@blankdots blankdots requested a review from a team December 20, 2023 11:36
@aaperis aaperis mentioned this pull request Dec 20, 2023
2 tasks
@aaperis
Copy link
Contributor Author

aaperis commented Dec 20, 2023

I noticed that there are some Issue templates here that seem somewhat obsolete. Do we keep them? If yes, I can add a mention to these cases as well.

those don't seem relevant now, except the new question.

also we might want to adjust the Pull request template to https://github.com/neicnordic/sensitive-data-archive/blob/main/.github/PULL_REQUEST_TEMPLATE.md as it is simpler

Opened #102 PR with changes regarding the github templates.

@blankdots blankdots merged commit 5c93c04 into master Dec 20, 2023
3 checks passed
@blankdots blankdots deleted the docs/rework-contribution-guidelines branch December 20, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants