Create 0280-wiggle-sort.java #3717
Open
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ykhan799
reviewed
Nov 5, 2024
Comment on lines
+3
to
+5
| for(int i = 1; i < nums.length; i++){ | ||
| if((i % 2 == 0 && nums[i] > nums[i - 1]) | ||
| || (i % 2 == 1 && nums[i] < nums[i - 1])) |
There was a problem hiding this comment.
It's better to have a space after control flow statements. There should also be an additional space between the for loop and the opening bracket
Ykhan799
reviewed
Nov 5, 2024
Comment on lines
+9
to
+10
| private void swap(int[] nums, int i, int j){ | ||
| int temp = nums[i]; |
There was a problem hiding this comment.
Add a space before the opening bracket
|
@dmgodoy Solution looks good. Please address my comments regarding spacing. The spaces will help improve readability of your code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.