added support for osname property

[pradeepbansal00]

No description provided.

[coveralls]

Coverage decreased (-0.03%) to 85.469% when pulling b3377f0 on pradeepbansal00:osname into 1cdee21 on nebula-plugins:master.

[rpalcolea]

Hi @pradeepbansal00!

First at all, thanks for your contribution.

What's the motivation behind adding osName and not using existing os?

Also, could you add tests around this?

Looking forward to hear from you

[pradeepbansal00]

Hi @rpalcolea ,
Nebula ospackage plugin's 'os' property is based on an enum, and it only accepts values from that enum, so 'aix' is acceptable, but 'aix7.1' is not. Meanwhile the rpmrc on AIX specifies a list of acceptable OS strings, all of which are 'aix' plus an OS version, and 'aix' without a version is not an acceptable string.

So we modified the ospackage plugin to add a new 'osName' property that takes a string instead, and tweaked logic a little so it uses 'osName' for the OS string if it's set, otherwise it uses 'os'

Regarding unit test, i will see if i can add some UT around osName