Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed nccl topology file and changed nccl-test image url. #101

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Removed nccl topology file and changed nccl-test image url. #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 4 additions & 39 deletions modules/nccl-test/files/helm/nccl-test/templates/nccl-test-h100.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ metadata:
labels:
{{- include "nccl-test.labels" . | nindent 4 }}
spec:
slotsPerWorker: 8 # Number of GPUs on each node
mpiReplicaSpecs:
Launcher:
replicas: 1
Expand All @@ -25,7 +26,7 @@ spec:
value: "1"
- name: OMPI_ALLOW_RUN_AS_ROOT_CONFIRM
value: "1"
image: cr.ai.nebius.cloud/crnu1co0h490t3i3or4c/nccl-tests:latest
image: cr.nemax.nebius.cloud/examples/nccl-tests:latest
name: nccl
resources:
requests:
Expand All @@ -47,42 +48,13 @@ spec:
template:
spec:
automountServiceAccountToken: false
# initContainers:
# - name: wait-for-node-ready
# image: bitnami/kubectl:latest
# command: ["/bin/bash", "-c"]
# args:
# - |
# LABEL_KEY="nvidia.com/gpu-driver-upgrade-state"
# LABEL_VALUE="upgrade-done"
# # Wait for the node to have the specified label and value
# while true; do
# NODE_NAME=$(kubectl get pod $HOSTNAME -o jsonpath='{.spec.nodeName}') &&
# LABEL_CURRENT_VALUE=$(kubectl get node $NODE_NAME -o jsonpath="{.metadata.labels.$LABEL_KEY}") &&
# echo "Current label value: $LABEL_CURRENT_VALUE" &&
# if [[ "$LABEL_CURRENT_VALUE" == "$LABEL_VALUE" ]]; then
# echo "Node $NODE_NAME is ready."
# break
# else
# echo "Waiting for node $NODE_NAME to be ready..."
# sleep 10
# fi
# done
# env:
# - name: HOSTNAME
# valueFrom:
# fieldRef:
# fieldPath: metadata.name
containers:
- env:
- name: NCCL_TOPO_FILE
value: /etc/nccl-topo-h100-v1.xml
image: cr.ai.nebius.cloud/crnu1co0h490t3i3or4c/nccl-tests:latest
- image: cr.nemax.nebius.cloud/examples/nccl-tests:latest
name: nccl
resources:
limits:
cpu: 108
memory: 1200G
memory: 1600G
nvidia.com/gpu: 8
requests:
cpu: 108
Expand All @@ -93,9 +65,6 @@ spec:
volumeMounts:
- mountPath: /dev/shm
name: dshm
- mountPath: /etc/nccl-topo-h100-v1.xml
name: config
subPath: nccl-topo-h100-v1.xml
enableServiceLinks: false
initContainers:
- command:
Expand All @@ -110,9 +79,5 @@ spec:
- emptyDir:
medium: Memory
name: dshm
- configMap:
name: {{ include "nccl-test.fullname" . }}-topo-config
name: config
runPolicy:
cleanPodPolicy: Running
slotsPerWorker: 8
9 changes: 0 additions & 9 deletions modules/nccl-test/files/helm/nccl-test/templates/topo-config.yaml
View file
Open in desktop

This file was deleted.

74 changes: 1 addition & 73 deletions modules/nccl-test/files/helm/nccl-test/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,74 +1,2 @@
numberOfHosts: 2
kubernetesClusterDomain: cluster.local
topoConfig:
ncclTopoH100V1Xml: |-
<system version="1">
<cpu numaid="0" affinity="00000000,00000000,0000ffff,ffffffff,ffffffff" arch="x86_64" vendor="GenuineIntel" familyid="6" modelid="106">
<pci busid="0000:8a:00.0" class="0x060400" vendor="0x104c" device="0x8232" subsystem_vendor="0x0000" subsystem_device="0x0000" link_speed="32.0 GT/s PCIe" link_width="16">
<pci busid="0000:8c:00.0" class="0x020700" vendor="0x15b3" device="0x101e" subsystem_vendor="0x15b3" subsystem_device="0x0023" link_speed="32.0 GT/s PCIe" link_width="16">
<nic>
<net name="mlx5_4" dev="4" speed="400000" port="1" latency="0.000000" maxconn="131072" gdr="1" coll="1"/>
</nic>
</pci>
<pci busid="0000:8d:00.0" class="0x030200" vendor="0x10de" device="0x2330" subsystem_vendor="0x10de" subsystem_device="0x16c1" link_speed="32.0 GT/s PCIe" link_width="16"/>
</pci>
<pci busid="0000:8e:00.0" class="0x060400" vendor="0x104c" device="0x8232" subsystem_vendor="0x0000" subsystem_device="0x0000" link_speed="32.0 GT/s PCIe" link_width="16">
<pci busid="0000:90:00.0" class="0x020700" vendor="0x15b3" device="0x101e" subsystem_vendor="0x15b3" subsystem_device="0x0023" link_speed="32.0 GT/s PCIe" link_width="16">
<nic>
<net name="mlx5_5" dev="5" speed="400000" port="1" latency="0.000000" maxconn="131072" gdr="1" coll="1"/>
</nic>
</pci>
<pci busid="0000:91:00.0" class="0x030200" vendor="0x10de" device="0x2330" subsystem_vendor="0x10de" subsystem_device="0x16c1" link_speed="32.0 GT/s PCIe" link_width="16"/>
</pci>
<pci busid="0000:92:00.0" class="0x060400" vendor="0x104c" device="0x8232" subsystem_vendor="0x0000" subsystem_device="0x0000" link_speed="32.0 GT/s PCIe" link_width="16">
<pci busid="0000:94:00.0" class="0x020700" vendor="0x15b3" device="0x101e" subsystem_vendor="0x15b3" subsystem_device="0x0023" link_speed="32.0 GT/s PCIe" link_width="16">
<nic>
<net name="mlx5_6" dev="6" speed="400000" port="1" latency="0.000000" maxconn="131072" gdr="1" coll="1"/>
</nic>
</pci>
<pci busid="0000:95:00.0" class="0x030200" vendor="0x10de" device="0x2330" subsystem_vendor="0x10de" subsystem_device="0x16c1" link_speed="32.0 GT/s PCIe" link_width="16"/>
</pci>
<pci busid="0000:96:00.0" class="0x060400" vendor="0x104c" device="0x8232" subsystem_vendor="0x0000" subsystem_device="0x0000" link_speed="32.0 GT/s PCIe" link_width="16">
<pci busid="0000:98:00.0" class="0x020700" vendor="0x15b3" device="0x101e" subsystem_vendor="0x15b3" subsystem_device="0x0023" link_speed="32.0 GT/s PCIe" link_width="16">
<nic>
<net name="mlx5_7" dev="7" speed="400000" port="1" latency="0.000000" maxconn="131072" gdr="1" coll="1"/>
</nic>
</pci>
<pci busid="0000:99:00.0" class="0x030200" vendor="0x10de" device="0x2330" subsystem_vendor="0x10de" subsystem_device="0x16c1" link_speed="32.0 GT/s PCIe" link_width="16"/>
</pci>
</cpu>
<cpu numaid="1" affinity="ffffffff,ffffffff,ffff0000,00000000,00000000" arch="x86_64" vendor="GenuineIntel" familyid="6" modelid="106">
<pci busid="0000:a8:00.0" class="0x060400" vendor="0x104c" device="0x8232" subsystem_vendor="0x0000" subsystem_device="0x0000" link_speed="32.0 GT/s PCIe" link_width="16">
<pci busid="0000:aa:00.0" class="0x020700" vendor="0x15b3" device="0x101e" subsystem_vendor="0x15b3" subsystem_device="0x0023" link_speed="32.0 GT/s PCIe" link_width="16">
<nic>
<net name="mlx5_0" dev="0" speed="400000" port="1" latency="0.000000" maxconn="131072" gdr="1" coll="1"/>
</nic>
</pci>
<pci busid="0000:ab:00.0" class="0x030200" vendor="0x10de" device="0x2330" subsystem_vendor="0x10de" subsystem_device="0x16c1" link_speed="32.0 GT/s PCIe" link_width="16"/>
</pci>
<pci busid="0000:ac:00.0" class="0x060400" vendor="0x104c" device="0x8232" subsystem_vendor="0x0000" subsystem_device="0x0000" link_speed="32.0 GT/s PCIe" link_width="16">
<pci busid="0000:ae:00.0" class="0x020700" vendor="0x15b3" device="0x101e" subsystem_vendor="0x15b3" subsystem_device="0x0023" link_speed="32.0 GT/s PCIe" link_width="16">
<nic>
<net name="mlx5_1" dev="1" speed="400000" port="1" latency="0.000000" maxconn="131072" gdr="1" coll="1"/>
</nic>
</pci>
<pci busid="0000:af:00.0" class="0x030200" vendor="0x10de" device="0x2330" subsystem_vendor="0x10de" subsystem_device="0x16c1" link_speed="32.0 GT/s PCIe" link_width="16"/>
</pci>
<pci busid="0000:b0:00.0" class="0x060400" vendor="0x104c" device="0x8232" subsystem_vendor="0x0000" subsystem_device="0x0000" link_speed="32.0 GT/s PCIe" link_width="16">
<pci busid="0000:b2:00.0" class="0x020700" vendor="0x15b3" device="0x101e" subsystem_vendor="0x15b3" subsystem_device="0x0023" link_speed="32.0 GT/s PCIe" link_width="16">
<nic>
<net name="mlx5_2" dev="2" speed="400000" port="1" latency="0.000000" maxconn="131072" gdr="1" coll="1"/>
</nic>
</pci>
<pci busid="0000:b3:00.0" class="0x030200" vendor="0x10de" device="0x2330" subsystem_vendor="0x10de" subsystem_device="0x16c1" link_speed="32.0 GT/s PCIe" link_width="16"/>
</pci>
<pci busid="0000:b4:00.0" class="0x060400" vendor="0x104c" device="0x8232" subsystem_vendor="0x0000" subsystem_device="0x0000" link_speed="32.0 GT/s PCIe" link_width="16">
<pci busid="0000:b6:00.0" class="0x020700" vendor="0x15b3" device="0x101e" subsystem_vendor="0x15b3" subsystem_device="0x0023" link_speed="32.0 GT/s PCIe" link_width="16">
<nic>
<net name="mlx5_3" dev="3" speed="400000" port="1" latency="0.000000" maxconn="131072" gdr="1" coll="1"/>
</nic>
</pci>
<pci busid="0000:b7:00.0" class="0x030200" vendor="0x10de" device="0x2330" subsystem_vendor="0x10de" subsystem_device="0x16c1" link_speed="32.0 GT/s PCIe" link_width="16"/>
</pci>
</cpu>
</system>
kubernetesClusterDomain: cluster.local