-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔄 synced file(s) with nebari-dev/nebari #526
Conversation
✅ Deploy Preview for nebari-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d880371
to
e434b0d
Compare
This PR is syncing release notes from the main repo. However, there are syntax errors with docusaurus v3. Essentially, I fixed these issues in the docusaurus v3 PR, but since this file is auto-pushed from the main repo, those changes need to be made over there. |
39f41f2
to
e754473
Compare
….md' MAINT - Sync release notes 🤖
e754473
to
7f3b5e9
Compare
@kcpevey given that the release notes are automatically generated by GitHub Releases, is there anything else we can do on the docs side? Or do we need to come up with some kind of pre-processing on the GHA workflow to make whatever changes are needed? |
Hi @marcelovilla, This has been discussed previously. What we need to do to unblock this is to run the same validation we run here in the docs in the current source code to assert that these files are compatible with Docssaurus. However, last week, I suggested that instead of performing this, it seems counterproductive, in my opinion. Instead, we could fetch the RELEASE.md from the github repo during runtime in the docs. Here's a similar thing that I did for the schema json (though on draft): const defaultSchema: Schema = {
title: "ConfigSchema",
description: "The configuration schema for Nebari.",
type: "object",
properties: {}
};
function useSchema(schemaUrl: string, useLocal = false) {
const [schema, setSchema] = useState<Schema>(defaultSchema);
const [loading, setLoading] = useState(true);
const [error, setError] = useState<string | null>(null);
useEffect(() => {
if (useLocal) {
const resolver = new Resolver();
resolver.resolve(JSONSchema, {}).then((resolvedSchema) => {
setSchema(resolvedSchema.result);
});
setLoading(false);
setError(null);
} else {
async function fetchSchema() {
try {
const response = await fetch(schemaUrl, { headers: { 'Accept': 'application/json' } });
if (!response.ok) {
throw new Error(`Failed to fetch schema: ${response.status} ${response.statusText}`);
}
const json = await response.json();
const resolver = new Resolver();
const resolvedSchema = await resolver.resolve(json, {});
setSchema(resolvedSchema.result);
} catch (err) {
console.error('Error:', err);
setError(err.message);
} finally {
setLoading(false);
}
}
fetchSchema();
}
}, [schemaUrl, useLocal]);
return { schema, loading, error };
} |
synced local file(s) with nebari-dev/nebari.
Changed files
docs/docs/references/RELEASE.md
with remoteRELEASE.md
This PR was created automatically by the repo-file-sync-action workflow run #11078400861