Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle new error message, remove devMode. #1164

Merged
merged 10 commits into from
Aug 21, 2024

Conversation

paouvrard
Copy link
Member

Description

  • After the testnet protocol upgrade there is a new error message which prevents onboarding of Ethereum wallets.
  • Remove devMode to use native 0x accounts.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@paouvrard paouvrard changed the title fix: Handle new error message, remove devMode. fix(ethereum-wallets): Handle new error message, remove devMode. Aug 9, 2024
@github-actions github-actions bot changed the title fix(ethereum-wallets): Handle new error message, remove devMode. fix: Handle new error message, remove devMode. Aug 9, 2024
@paouvrard paouvrard marked this pull request as draft August 12, 2024 12:12
@paouvrard paouvrard marked this pull request as ready for review August 12, 2024 14:03
@pivanov pivanov self-requested a review August 20, 2024 11:43
It should work with the next wallet-selector release after other
wallet packages have removed naj v3 from dependencies.
packages/ethereum-wallets/src/lib/index.ts Outdated Show resolved Hide resolved
packages/ethereum-wallets/src/lib/index.ts Outdated Show resolved Hide resolved
@paouvrard paouvrard requested a review from pivanov August 21, 2024 08:31
@pivanov pivanov merged commit 9721964 into near:dev Aug 21, 2024
5 checks passed
@pivanov pivanov mentioned this pull request Sep 11, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

2 participants