Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix react sample startup guide & add needful dependency … #1128

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

AlienegraGeek
Copy link

@AlienegraGeek AlienegraGeek commented Jul 3, 2024

Description

Refined the guidance for example and added a required dependency that otherwise would have prevented the sample service from starting due to dependency and build issues.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@trechriron trechriron requested review from trechriron and hcho112 and removed request for trechriron July 15, 2024 22:12
Copy link
Collaborator

@trechriron trechriron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the initial branch merge to DEV. Thanks!

Added images to the Submitting a PR section. Uploaded images in a separate commit.
@AlienegraGeek AlienegraGeek changed the base branch from main to dev July 16, 2024 08:05
@github-actions github-actions bot changed the title docs(react): fix react sample startup guide & add needful dependency … docs: fix react sample startup guide & add needful dependency … Jul 16, 2024
@AlienegraGeek
Copy link
Author

AlienegraGeek commented Jul 16, 2024

Please change the initial branch merge to DEV. Thanks!

Done.

trechriron
trechriron previously approved these changes Jul 16, 2024
examples/react/README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
pivanov
pivanov previously approved these changes Jul 19, 2024
Copy link
Collaborator

@pivanov pivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)
r+

@AlienegraGeek AlienegraGeek dismissed pivanov’s stale review July 19, 2024 07:24

The merge-base changed after approval.

@frol
Copy link
Collaborator

frol commented Jul 19, 2024

@AlienegraGeek Sorry for jumping in, but I'd like to invite you to participate in the Race of Sloths - a fun and gamified open-source contributions program. Consider mentioning @race-of-sloths user in your github comment or PR description to join!

See how the flow works here: near/nearcore#11778

@AlienegraGeek
Copy link
Author

@race-of-sloths

@trechriron trechriron mentioned this pull request Jul 24, 2024
14 tasks
@pivanov pivanov self-requested a review August 2, 2024 05:57
pivanov
pivanov previously approved these changes Aug 2, 2024
Copy link
Collaborator

@pivanov pivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@AlienegraGeek AlienegraGeek dismissed pivanov’s stale review August 2, 2024 05:58

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: NEW❗
Development

Successfully merging this pull request may close these issues.

4 participants