Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(resharding): base resharding scenario state cleanup #12678

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

staffik
Copy link
Contributor

@staffik staffik commented Jan 3, 2025

A test for cleanup after resharding.
Adds an extra client without a role, that initially tracks the parent shard, then a child shard, and then an unrelated shard.
After a few epochs, only the last tracked shard should reside in State, while currently the test fails because it has entries from the first tracked shard too.

Changes

  • Fix a bug in test infra: pass gc_num_epochs_to_keep to the runtime.
  • Add tracked_shard_schedule option to resharding testloop, in order to test the cleanup.
  • Add the cleanup test itself (ignored for now).

@staffik staffik requested review from wacban and Trisfald January 3, 2025 12:36
@staffik staffik requested a review from a team as a code owner January 3, 2025 12:36
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 5.61798% with 84 lines in your changes missing coverage. Please review.

Project coverage is 70.53%. Comparing base (21b5109) to head (aa701ce).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ntegration-tests/src/test_loop/utils/resharding.rs 0.00% 84 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12678      +/-   ##
==========================================
- Coverage   70.56%   70.53%   -0.04%     
==========================================
  Files         847      847              
  Lines      172735   172823      +88     
  Branches   172735   172823      +88     
==========================================
+ Hits       121897   121898       +1     
- Misses      45737    45824      +87     
  Partials     5101     5101              
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (ø)
db-migration 0.16% <0.00%> (?)
genesis-check 1.36% <0.00%> (-0.01%) ⬇️
linux 69.22% <5.61%> (-0.03%) ⬇️
linux-nightly 70.11% <5.61%> (-0.06%) ⬇️
pytests 1.66% <0.00%> (-0.01%) ⬇️
sanity-checks 1.47% <0.00%> (-0.01%) ⬇️
unittests 70.36% <5.61%> (-0.04%) ⬇️
upgradability 0.20% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@staffik staffik requested a review from Trisfald January 3, 2025 16:32
Copy link
Contributor

@Trisfald Trisfald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@staffik staffik added this pull request to the merge queue Jan 3, 2025
Merged via the queue into master with commit 77b4ab2 Jan 3, 2025
28 checks passed
@staffik staffik deleted the stafik/resharding/state-cleanup branch January 3, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants