feat: parallel partial witness handling in the partial witness actor #12656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12656 +/- ##
=======================================
Coverage 70.59% 70.59%
=======================================
Files 847 847
Lines 173209 173250 +41
Branches 173209 173250 +41
=======================================
+ Hits 122271 122302 +31
- Misses 45825 45841 +16
+ Partials 5113 5107 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stedfn
changed the title
stedfn
changed the title
stedfn
commented
Jan 3, 2025
chain/client/src/stateless_validation/partial_witness/partial_witness_actor.rs
Show resolved
Hide resolved
| "Received invalid partial encoded state witness" | ||
| ); | ||
| } | ||
| Err(err) => { |
There was a problem hiding this comment.
I don't particularly like how we have the handling of the cases here but I don't see another way out due to the async spawn..
There was a problem hiding this comment.
I agree, I wasn't sure what to do about it either
chain/client/src/stateless_validation/partial_witness/partial_witness_tracker.rs
Outdated
Show resolved
Hide resolved
chain/client/src/stateless_validation/partial_witness/partial_witness_tracker.rs
Outdated
Show resolved
Hide resolved
chain/client/src/stateless_validation/partial_witness/partial_witness_tracker.rs
Show resolved
Hide resolved
shreyan-gupta
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR unblocks the main thread of the
PartialWitnessActorby detaching the handling of the partial witnesses to separate threads.This results in a considerable reduction in the distribution latency of the state witness:
The image originates from a forknet experiment with 50 nodes, with each state witness artificially padded to reach a size of 30 MB.