Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metric for number of chunks excluded from the block due to insufficient endorsement #12562

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

pugachAG
Copy link
Contributor

@pugachAG pugachAG commented Dec 5, 2024

No description provided.

@pugachAG pugachAG requested a review from a team as a code owner December 5, 2024 17:43
@pugachAG pugachAG changed the title feat: add metric for number of chunk excluded from the block due to insufficient endorsement feat: add metric for number of chunks excluded from the block due to insufficient endorsement Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (6af8e01) to head (606940d).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12562   +/-   ##
=======================================
  Coverage   70.13%   70.13%           
=======================================
  Files         841      841           
  Lines      169899   169912   +13     
  Branches   169899   169912   +13     
=======================================
+ Hits       119156   119167   +11     
- Misses      45605    45607    +2     
  Partials     5138     5138           
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (-0.01%) ⬇️
db-migration 0.16% <0.00%> (-0.01%) ⬇️
genesis-check 1.29% <0.00%> (-0.01%) ⬇️
linux 69.36% <100.00%> (-0.01%) ⬇️
linux-nightly 69.71% <100.00%> (-0.01%) ⬇️
pytests 1.59% <0.00%> (-0.01%) ⬇️
sanity-checks 1.40% <0.00%> (-0.01%) ⬇️
unittests 69.95% <100.00%> (+<0.01%) ⬆️
upgradability 0.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For this metric to work sensibly we need to collect the metrics from the block producers in production. Do you happen to know where do we stand on that?

@pugachAG pugachAG added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 6, 2024
@pugachAG pugachAG added this pull request to the merge queue Dec 6, 2024
Merged via the queue into master with commit 5196eb9 Dec 6, 2024
27 checks passed
@pugachAG pugachAG deleted the insufficient-endorsement-metric branch December 6, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants