Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the 'insta' dependency to version 1.37.0 to fix cargo audit warning #10880

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

jancionear
Copy link
Contributor

Recently cargo audit started complaining that the yaml-rust dependency is unmaintained (#10876). yaml-rust is an indirect dependency that comes from the insta crate, so to fix the warning we must upgrade insta to a version that doesn't have this problem.
The insta crate just had a new release which fixes the problem detected by cargo audit (they pasted the whole yaml-rust crate into their tree x.x (mitsuhiko/insta#465)). We can upgrade to the latest version to get rid of the warning.

Upgrading to the latest version is relatively painless, I just had to replace assert_display_snapshot with assert_snapshot because assert_display_snapshot is now deprecated (see https://github.com/mitsuhiko/insta/blob/8379841b8fde1cbd2fee019a9207ebea3619658f/src/macros.rs#L372)

Fixes: #10876

@jancionear jancionear requested a review from a team as a code owner March 26, 2024 14:37
@jancionear jancionear requested a review from wacban March 26, 2024 14:37
@jancionear jancionear added the C-housekeeping Category: Refactoring, cleanups, code quality label Mar 26, 2024
@jancionear
Copy link
Contributor Author

jancionear commented Mar 26, 2024

@wacban is currently unavailable, so I'll request another reviewer

@jancionear jancionear requested a review from Ekleog-NEAR March 26, 2024 14:55
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.64%. Comparing base (fc0cd0e) to head (2fdaa55).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10880      +/-   ##
==========================================
+ Coverage   71.43%   71.64%   +0.20%     
==========================================
  Files         758      758              
  Lines      151918   151918              
  Branches   151918   151918              
==========================================
+ Hits       108530   108836     +306     
+ Misses      38855    38542     -313     
- Partials     4533     4540       +7     
Flag Coverage Δ
backward-compatibility 0.24% <ø> (?)
db-migration 0.24% <ø> (?)
genesis-check 1.42% <ø> (?)
integration-tests 37.39% <0.00%> (+0.11%) ⬆️
linux 70.27% <100.00%> (+0.13%) ⬆️
linux-nightly 71.14% <100.00%> (+0.01%) ⬆️
macos 53.02% <100.00%> (-1.72%) ⬇️
pytests 1.65% <ø> (?)
sanity-checks 1.44% <ø> (?)
unittests 67.28% <100.00%> (+<0.01%) ⬆️
upgradability 0.29% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ekleog-NEAR
Copy link
Collaborator

Thank you for the fixing! :)

@jancionear jancionear added this pull request to the merge queue Mar 26, 2024
Merged via the queue into near:master with commit eee6205 Mar 26, 2024
31 checks passed
@jancionear jancionear deleted the instafix branch March 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo audit check fails because yaml-rust is unmaintained
2 participants