Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example for docs of migration #400

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

fospring
Copy link
Contributor

@fospring fospring commented Jun 2, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

for the example of https://docs.near.org/build/smart-contracts/release/upgrade

Test Plan

Related issues/PRs

@ailisp
Copy link
Member

ailisp commented Jun 3, 2024

Code looks good! have you test the contract? It would be best to have a test included and at least manually tested with CLI. If tested with CLI, also mention the command in doc!

@fospring
Copy link
Contributor Author

fospring commented Jun 3, 2024

Code looks good! have you test the contract? It would be best to have a test included and at least manually tested with CLI. If tested with CLI, also mention the command in doc!

ok,test file and cli command added, mention command and testfile in this MR

Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ailisp ailisp merged commit 8e99e21 into near:develop Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants