fix: newest AWS updates failing on localstack #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChaoticTempest I see. Since it is pretty common case and related to the localstack usage, can you consider introducing a feature (e.g. |
|
seems like with node version 1.40, this isn't happening anymore. Quite weird, so closing this one for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if this should be merged in or not. The latest AWS sdk dependency updates with node version 1.40 changes the way requests are being sent where localstack will interpret the first item in the path as the bucket since testing with localstack requires s3 in one of the prefixes for the domain name to have
virtual hosted? So this change makes into apathbased.For more information, look at related issue in localstack: localstack/localstack#9951
@khorolets not sure if this is working properly on the NEAR node side with actual AWS. Could also make this a parameter to change up the path for localstack testing