Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isModal config on FastAuthWallet #36

Merged
merged 21 commits into from
Oct 24, 2024
Merged

Add isModal config on FastAuthWallet #36

merged 21 commits into from
Oct 24, 2024

Conversation

Pessina
Copy link
Contributor

@Pessina Pessina commented Oct 5, 2024

#Summary

This PR introduces an option for the caller to choose whether the wallet should be rendered inside a modal or not, making it easier to customize the UI.

Usage

Render the wallet in a modal (default behavior):

setupFastAuthWallet({
  relayerUrl,
  walletUrl: 'http://localhost:3000',
});

Render the wallet without a modal:

setupFastAuthWallet({
  relayerUrl,
  walletUrl: 'http://localhost:3000',
  isModal: false,
});

@charlesmooredev
Copy link

Hey, any updates on the ETA?

@Pessina
Copy link
Contributor Author

Pessina commented Oct 18, 2024

@charlesmooredev sorry, it took more time than expected to use Shadcn for the UI.

But I asked @esaminu for review it again

@Pessina Pessina requested a review from esaminu October 18, 2024 11:50
esaminu
esaminu previously approved these changes Oct 18, 2024
Copy link
Collaborator

@esaminu esaminu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@esaminu esaminu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pessina Pessina merged commit 76b88da into main Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants