Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #18, this is another community pull request. The mock signer has been out of date and this pull request modifies a few things to return a result identical to what we can expect from the contract currently deployed to
v5.multichain-mpc-dev.testnet
.You may modify and run this command to see the result:
and you will see this result:
This pull request quickly catches up the sign method with the latest breaking changes to the arguments, and the breaking changes involved in the structure of the response. See this screenshot comparing the two:
On the left window, you see the mock contract from this pull request built (not optimized) and deployed to
mock-mpc.mike.testnet
, which folks are free to use instead of deploying their own, obviously.At the time of this writing, it feels rather important for developers to have an alternate contract since the v2 contract (
v2.multichain-mpc.testnet
) hasn't been updated to allow for the 1 yoctoNEAR requirement. So the contract at that address is unfortunately, not "forward-compatible" because it will throw an error when a builder attempts to develop a proper workflow in line with security concerns.Recommendation to include a brief page in docs about how a builder can use a mock contract.