Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Smart Contract Section #1106

Merged
merged 292 commits into from
Jul 19, 2022
Merged

Add Smart Contract Section #1106

merged 292 commits into from
Jul 19, 2022

Conversation

idea404
Copy link
Contributor

@idea404 idea404 commented Jul 18, 2022

This PR adds content for the smart contract and state sections in 1.basics under 1.concepts

@idea404 idea404 requested a review from gagdiez July 18, 2022 12:08
@idea404 idea404 requested a review from bucanero as a code owner July 18, 2022 12:08
@idea404
Copy link
Contributor Author

idea404 commented Jul 18, 2022

@gagdiez @bucanero I added these paragraphs to this section, by adding more I felt it would overlap too much with other parts of the docs. In part I'm not sure if this info is really adding anything here. What do you think?

Guillermo did you have something like this in mind here?

@gagdiez
Copy link
Collaborator

gagdiez commented Jul 18, 2022

@idea404 this section is more "explaining what a smart contract is to your grandma", so we only really need to explain that a smart contract is a small program stored on a blockchain, that anyone can access it, and that it has a storage (that anyone can see but only the contract change).

@bucanero bucanero changed the base branch from newdocs to master July 18, 2022 17:56
@bucanero bucanero changed the base branch from master to newdocs July 18, 2022 17:56
@bucanero bucanero changed the base branch from newdocs to master July 18, 2022 20:27
@render
Copy link

render bot commented Jul 19, 2022

@idea404
Copy link
Contributor Author

idea404 commented Jul 19, 2022

I've simplified the contents for both sections @gagdiez. What do you think?

@gagdiez gagdiez merged commit 6b893b0 into master Jul 19, 2022
@gagdiez gagdiez deleted the smart-contracts branch July 19, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants