Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ser/de for IpAddr type; schema for Ipv4Addr/Ipv6Addr/IpAddr types #309

Merged
merged 13 commits into from
Oct 8, 2024

Conversation

willco-1
Copy link
Contributor

this is a WIP attempt to add the base IpAddr type to the schema.

@willco-1 willco-1 closed this Sep 11, 2024
@willco-1 willco-1 reopened this Sep 11, 2024
@willco-1 willco-1 closed this Sep 11, 2024
@willco-1 willco-1 reopened this Sep 11, 2024
Copy link
Collaborator

@dj8yfo dj8yfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willco-1 do you plan on finishing the pr?

borsh/tests/schema/test_ip_addr.rs Show resolved Hide resolved
borsh/src/ser/mod.rs Outdated Show resolved Hide resolved
borsh/tests/schema/test_ip_addr.rs Outdated Show resolved Hide resolved
@willco-1
Copy link
Contributor Author

@dj8yfo yes! Sorry .. I got busy and forgot to come back to it. Thanks for the tips, this is very helpful.

borsh/tests/schema/test_ip_addr.rs Outdated Show resolved Hide resolved
borsh/tests/schema/test_ip_addr.rs Outdated Show resolved Hide resolved
borsh/tests/tests.rs Show resolved Hide resolved
fuzz/fuzz-run/src/main.rs Outdated Show resolved Hide resolved
borsh/src/ser/mod.rs Outdated Show resolved Hide resolved
borsh/tests/tests.rs Show resolved Hide resolved
@dj8yfo dj8yfo marked this pull request as draft October 8, 2024 20:19
@dj8yfo dj8yfo changed the title WIP: add IpAddr type feat: ser/de for IpAddr type; schema for Ipv4Addr/Ipv6Addr/IpAddr types Oct 8, 2024
@dj8yfo
Copy link
Collaborator

dj8yfo commented Oct 8, 2024

@race-of-sloths include

@dj8yfo dj8yfo marked this pull request as ready for review October 8, 2024 21:00
@race-of-sloths-bot
Copy link

@dj8yfo Thank you for calling!

@willco-1 Thank you for the contribution! Join Race of Sloths by simply mentioning me in your comment/PRs description and start collecting Sloth Points through contributions to open source projects.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@dj8yfo
Copy link
Collaborator

dj8yfo commented Oct 8, 2024

@race-of-sloths score 3

@race-of-sloths-bot
Copy link

@dj8yfo Thank you for calling!

@willco-1 Thank you for the contribution! Join Race of Sloths by simply mentioning me in your comment/PRs description and start collecting Sloth Points through contributions to open source projects.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@dj8yfo dj8yfo merged commit b416d11 into near:master Oct 8, 2024
7 checks passed
@frol frol mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants