Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix tests #16

Merged
merged 3 commits into from
Sep 19, 2023
Merged

tests: fix tests #16

merged 3 commits into from
Sep 19, 2023

Conversation

MatteoVoges
Copy link
Member

Fixes issue #

Proposed Changes

@MatteoVoges MatteoVoges marked this pull request as ready for review September 19, 2023 10:57
@MatteoVoges MatteoVoges self-assigned this Sep 19, 2023
@MatteoVoges MatteoVoges requested a review from jrod-97 September 19, 2023 10:57
@@ -94,6 +94,7 @@ def test_migration_meta_interpolation(self):
self.assertEqual(migrated, expected)


@unittest.skip("Pool issues")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is currently a caching issue in the process pool when rendering the inventory.

  1. I want to migrate the tests into using pytest in the near future, because it offers testcases as values and not as functions
  2. Caching in Inventory has already changed with the upcoming refactoring

@MatteoVoges MatteoVoges merged commit fd11c94 into dev Sep 19, 2023
@MatteoVoges MatteoVoges deleted the fix-tests branch September 19, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants