Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set a few additional envvars to pass context to apps #20

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

bodom0015
Copy link
Member

@bodom0015 bodom0015 commented Jan 11, 2024

Problems

Some applications rely on legacy envvars that were set in Workbench V1 (for example, cloudcmd)

Workbench V2 should also set similar values, so that these applications can be used in V2

List of potentially affected apps:

  • CKAN (PostgreSQL ADDR/PORT may still be present)
  • Girder (MongoDB ADDR/PORT may still be present)
  • Suave (MongoDB ADDR may still be present)
  • CloudCmd (NAMESPACE)
  • CHORDS? (CHORDS_ADMIN_PW should still be present)
  • DSpace (PostgreSQL ADDR / NDSLABS_EMAIL)
  • Dataverse / TwoRavens (NDSLABS_STACK / NDSLABS_DOMAIN)

Approach

  • feat: set a few additional envvars to pass context to apps

How to Test

  1. Checkout and run this branch locally (see workbench-helm-chart)
  2. Navigate to https://kubernetes.docker.internal/ (ignore browser certificate warnings)
  3. Login/register with Keycloak
    • You should be brought back to the Workbench, now logged in
  4. Add an application from the "All Apps"
    • You should be brought to "My Apps" to see your new app
  5. Launch the application
    • You should see the application turn green when it is ready
  6. Click the Console link on the "My Apps" page
    • You should see a web terminal open in your browser
  7. In the Console, type env | grep NDSLABS_
    • You should see the values of 4 additional variables are printed: NDSLABS_STACK, NDSLABS_USER, NDSLABS_NAMESPACE, NDSLABS_SERVICE

@bodom0015 bodom0015 merged commit 909cf85 into develop Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant