Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #168

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactoring #168

wants to merge 2 commits into from

Conversation

ndokter
Copy link
Owner

@ndokter ndokter commented Dec 22, 2024

  • Moved the decryption logic to own method to make parse a bit more readable
  • Simplified it a bit by removing the double if layer which seems unneeded
  • If encryption is not working, log a warning once and then stop logging warnings
    • Maybe we should enforce encryption if you are setting a key for it. But i'm not 100% sure if that has side effects
  • Moved client tests to their own folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant