Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add encrytion_key and authentication_key functionallity for a protocol client #146

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skrutzler
Copy link

The current implementation is only allowing the parser object to use a encryption and authentication key.

With this pull request it should now also be possible to use those keys when only the client is used by a application.

Following that changes I plan to add the functionality in the home-assistant dsmr plugin https://github.com/home-assistant/core/tree/dev/homeassistant/components/dsmr

@skrutzler skrutzler marked this pull request as draft November 13, 2023 17:33
@dupondje
Copy link
Collaborator

Hi,

Thanks for your PR. You are still working on this as its still a draft.
Is it eventually possible to add a test with the encrypted data/telegram, and have it parsed? This way we can test the decryption also.

Let me know when it can be reviewed :)

@skrutzler
Copy link
Author

Hello,

yeah the PR is not ready yet. I was under the impression that the serial read was done for a full frame but apparently we read differently and that is not working out for decrypting telegrams which needs to have the full frame read (511bytes in my case) and then decrypt it.
I currently do not have much spare time to work on that but see if I can play around a bit more in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants