Code

Restructure API object attributes#16

Code

Open

amilligan wants to merge 78 commits intonbwar:masternbwar/onfleet:masterfrom buildgroundwork:attributesbuildgroundwork/onfleet:attributesCopy head branch name to clipboard

+1,444-308

Commits

Commits on May 13, 2018

• Explicitly specify ruby version

  amilligan

  committed
  d6319d6

Commits on May 14, 2018

• Include rubocop for style analysis

  amilligan

  committed
  00407c6

• Place dot operator consistently on multiline calls

  Show description for 0682175
  amilligan

  committed
  0682175

• Remove extraneous whitespace

  Show description for cd1055b
  amilligan

  committed
  cd1055b

• Indent consistently

  Show description for 919f9fc
  amilligan

  committed
  919f9fc

• Space parameters and operator consistently

  Show description for b293021
  amilligan

  committed
  b293021

• Include trailing line consistently in all files

  Show description for 93d2ddd
  amilligan

  committed
  93d2ddd

• Fix ambiguous regexp literal

  Show description for 348e28c
  amilligan

  committed
  348e28c

• Clarify assignment in conditional expressions

  Show description for ad197e1
  amilligan

  committed
  ad197e1

• Remove duplicate accessor method definition

  Show description for e502a76
  amilligan

  committed
  e502a76

• Make private methods actually private

  Show description for cd48ba8
  amilligan

  committed
  cd48ba8

• Replace obsolete method call

  Show description for 97cb0f8
  amilligan

  committed
  97cb0f8

• Remove useless variable assignments

  Show description for 95feef9
  amilligan

  committed
  95feef9

• Replace unnecessary hash merge

  Show description for 41d9e5b
  amilligan

  committed
  41d9e5b

• Prefer boolean operator in condition

  Show description for 32f770f
  amilligan

  committed
  32f770f

• Enforce consistent brace/paren/etc. style

  Show description for efc5b1f
  amilligan

  committed
  efc5b1f

• Use interpolated strings only when required

  Show description for 718b1eb
  amilligan

  committed
  718b1eb

• Remove unnecessary string interpolation

  Show description for 43f892e
  amilligan

  committed
  43f892e

• Remove redundant uses of self

  Show description for 69ee0a9
  amilligan

  committed
  69ee0a9

• Prefer parameterized method of raising exceptions

  Show description for 37a817e
  amilligan

  committed
  37a817e

• Use next to skip iteration

  Show description for cbcf708
  amilligan

  committed
  cbcf708

• Avoid unnecessarily negated conditions

  Show description for b8a1243
  amilligan

  committed
  b8a1243

• Freeze mutable objects set as constants

  Show description for aba084a
  amilligan

  committed
  aba084a

• Replace inverted use of select with reject

  Show description for f6237f0
  amilligan

  committed
  f6237f0

• Use modifier conditional syntax when applicable

  Show description for da65008
  amilligan

  committed
  da65008

• Add guard clause to method

  Show description for 7e822a2
  amilligan

  committed
  7e822a2

• Simplify file path expansion

  Show description for 382d668
  amilligan

  committed
  382d668

• Make rubocop accept the main gem filename

  amilligan

  committed
  2b64f88

• Remove redunant variable assignment

  Show description for 873cd93
  amilligan

  committed
  873cd93

• Consistently use #is_a? for class check

  Show description for ac57423
  amilligan

  committed
  ac57423

• Remove rubocop requirement for JavaDoc-style docs

  amilligan

  committed
  7b8dc0e

• Consistently use ruby-style variable names

  Show description for 9564afe
  amilligan

  committed
  9564afe

• Use descriptive method parameter names

  Show description for d8c5fac
  amilligan

  committed
  d8c5fac

• Rename method to avoid ambiguity with accessor

  Show description for 4814ab9
  amilligan

  committed
  4814ab9

• Creating TODO file for remaining rubocop issues

  amilligan

  committed
  2b693e8

• Add rake task for rubocop, and include in default

  amilligan

  committed
  a079b93

• Specify old-ish ruby (2.2) for rubocop

  amilligan

  committed
  f71e199

Commits on May 15, 2018

• Remove redundant gem dependency

  amilligan

  committed
  24d32ab

• Add missing gem dependency

  amilligan

  committed
  fd5fe47

• Add rspec with default configuration

  amilligan

  committed
  92610d2

• Add rake task for specs, and add to default

  amilligan

  committed
  f69610d

• Require project files in specs

  amilligan

  committed
  ac52777

• Add webmock gem for network testing

  amilligan

  committed
  d5e3e89

• Use URI.join to build URLs

  Show description for f387096
  amilligan

  committed
  f387096

• Add basic test for HTTP requests

  amilligan

  committed
  42f2960

• Extract common HTTP request test behavior

  amilligan

  committed
  0641421

• Simplify Organization creation methods

  amilligan

  committed
  f1ca55d

• Add basic specs for Organization attributes

  amilligan

  committed
  b604315

• Specialize shared examples for different requests

  amilligan

  committed
  560498b

• Add specs for API list behavior

  amilligan

  committed
  86b0023

• Add specs for API create behavior

  amilligan

  committed
  00ba2e1

• Add specs for API delete behavior

  amilligan

  committed
  8971fa7

• Add specs for API update behavior

  amilligan

  committed
  3d0ca01

• Add specs for API query by metadata behavior

  amilligan

  committed
  9079ae0

• Add specs for API save behavior

  amilligan

  committed
  2c120d6

• Add rspec helper dependency

  amilligan

  committed
  d464079

• Add specs for Destination object

  amilligan

  committed
  90aedd7

• Properly camelize request keys in expectations

  amilligan

  committed
  597a067

• Add specs for Recipient object

  amilligan

  committed
  08ec9dd

• Add specs for API find behavior

  amilligan

  committed
  d897ac1

• Add specs for Task object

  amilligan

  committed
  eb3cfd7

• Add specs for Team object

  amilligan

  committed
  726407a

• Add specs for Webhook object

  amilligan

  committed
  f37610c

• Add specs for Worker object

  amilligan

  committed
  cb77a2e

• Remove unnecessary utility method

  amilligan

  committed
  0f10434

• Replace utility methods with existing methods

  amilligan

  committed
  2cbfd93

• Move global function to class where it is used

  amilligan

  committed
  80cad85

• Add specs for Onfleet object initialization

  amilligan

  committed
  a768033

Commits on May 16, 2018

• Add DSL for Onfleet API objects

  amilligan

  committed
  771642d

• Rename attributes method for clarity

  amilligan

  committed
  62ce07c

• Replace dynamic instance variables with collection

  amilligan

  committed
  0d4d569

• Add DSL methods for specifying object associations

  amilligan

  committed
  5cfde55

• Add Hub Onfleet object

  amilligan

  committed
  0abf767

Commits on May 17, 2018

• Specify associated API objects with DSL

  amilligan

  committed
  ba694e4

• Encapsulate JSON-ification in API objects

  amilligan

  committed
  924d1d7

• Restore spec examples that are now deterministic

  amilligan

  committed
  6d636d5

• Camelize barcode attribute keys properly

  amilligan

  committed
  dc75abe

• Update rubocop TODO

  amilligan

  committed
  7582659